chat_completions_image_model_test.go 3.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596
  1. package handler
  2. import (
  3. "bytes"
  4. "context"
  5. "net/http"
  6. "net/http/httptest"
  7. "sync/atomic"
  8. "testing"
  9. "time"
  10. middleware "github.com/Wei-Shaw/sub2api/internal/server/middleware"
  11. "github.com/Wei-Shaw/sub2api/internal/service"
  12. "github.com/gin-gonic/gin"
  13. "github.com/stretchr/testify/require"
  14. "github.com/tidwall/gjson"
  15. )
  16. func TestChatCompletionsRejectsGPTImageModelsBeforeScheduling(t *testing.T) {
  17. gin.SetMode(gin.TestMode)
  18. for _, model := range []string{"gpt-image-1", "gpt-image-1.5", "gpt-image-2"} {
  19. for _, tc := range []struct {
  20. name string
  21. call func(*gin.Context)
  22. }{
  23. {
  24. name: "gateway",
  25. call: (&GatewayHandler{}).ChatCompletions,
  26. },
  27. {
  28. name: "openai_gateway",
  29. call: newOpenAIImageChatRejectionHandler(t).ChatCompletions,
  30. },
  31. } {
  32. t.Run(tc.name+"/"+model, func(t *testing.T) {
  33. recorder := httptest.NewRecorder()
  34. c, _ := gin.CreateTestContext(recorder)
  35. body := []byte(`{"model":"` + model + `","messages":[{"role":"user","content":"draw"}]}`)
  36. c.Request = httptest.NewRequest(http.MethodPost, "/v1/chat/completions", bytes.NewReader(body))
  37. setImageChatTestAuth(c)
  38. tc.call(c)
  39. require.Equal(t, http.StatusBadRequest, recorder.Code)
  40. require.Equal(t, "invalid_request_error", gjson.Get(recorder.Body.String(), "error.type").String())
  41. require.Contains(t, gjson.Get(recorder.Body.String(), "error.message").String(), "Chat Completions")
  42. _, selected := c.Get(opsAccountIDKey)
  43. require.False(t, selected, "rejection must happen before account selection")
  44. })
  45. }
  46. }
  47. }
  48. func TestOpenAIChatCompletionsImageModelRejectionDoesNotAcquireConcurrency(t *testing.T) {
  49. var acquireCalls atomic.Int64
  50. cache := &concurrencyCacheMock{
  51. acquireUserSlotFn: func(context.Context, int64, int, string) (bool, error) {
  52. acquireCalls.Add(1)
  53. return true, nil
  54. },
  55. }
  56. h := newOpenAIImageChatRejectionHandlerWithCache(t, cache)
  57. recorder := httptest.NewRecorder()
  58. c, _ := gin.CreateTestContext(recorder)
  59. c.Request = httptest.NewRequest(http.MethodPost, "/v1/chat/completions", bytes.NewBufferString(
  60. `{"model":"gpt-image-2","messages":[{"role":"user","content":"draw"}]}`,
  61. ))
  62. setImageChatTestAuth(c)
  63. h.ChatCompletions(c)
  64. require.Equal(t, http.StatusBadRequest, recorder.Code)
  65. require.Zero(t, acquireCalls.Load(), "rejection must happen before user/account concurrency and scheduling")
  66. }
  67. func newOpenAIImageChatRejectionHandler(t *testing.T) *OpenAIGatewayHandler {
  68. t.Helper()
  69. return newOpenAIImageChatRejectionHandlerWithCache(t, &concurrencyCacheMock{})
  70. }
  71. func newOpenAIImageChatRejectionHandlerWithCache(t *testing.T, cache *concurrencyCacheMock) *OpenAIGatewayHandler {
  72. t.Helper()
  73. return &OpenAIGatewayHandler{
  74. gatewayService: &service.OpenAIGatewayService{},
  75. billingCacheService: &service.BillingCacheService{},
  76. apiKeyService: &service.APIKeyService{},
  77. concurrencyHelper: NewConcurrencyHelper(service.NewConcurrencyService(cache), SSEPingFormatNone, time.Second),
  78. }
  79. }
  80. func setImageChatTestAuth(c *gin.Context) {
  81. apiKey := &service.APIKey{ID: 4348, UserID: 4348, User: &service.User{ID: 4348}}
  82. c.Set(string(middleware.ContextKeyAPIKey), apiKey)
  83. c.Set(string(middleware.ContextKeyUser), middleware.AuthSubject{UserID: apiKey.UserID, Concurrency: 1})
  84. }