payment_config_service_test.go 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556
  1. package service
  2. import (
  3. "context"
  4. "database/sql"
  5. "fmt"
  6. "strings"
  7. "testing"
  8. dbent "github.com/Wei-Shaw/sub2api/ent"
  9. "github.com/Wei-Shaw/sub2api/ent/enttest"
  10. "github.com/Wei-Shaw/sub2api/internal/payment"
  11. "entgo.io/ent/dialect"
  12. entsql "entgo.io/ent/dialect/sql"
  13. _ "modernc.org/sqlite"
  14. )
  15. func TestPcParseFloat(t *testing.T) {
  16. t.Parallel()
  17. tests := []struct {
  18. name string
  19. input string
  20. defaultVal float64
  21. expected float64
  22. }{
  23. {"empty string returns default", "", 1.0, 1.0},
  24. {"valid float", "3.14", 0, 3.14},
  25. {"valid integer as float", "42", 0, 42.0},
  26. {"invalid string returns default", "notanumber", 9.99, 9.99},
  27. {"zero value", "0", 5.0, 0},
  28. {"negative value", "-10.5", 0, -10.5},
  29. {"very large value", "99999999.99", 0, 99999999.99},
  30. }
  31. for _, tt := range tests {
  32. t.Run(tt.name, func(t *testing.T) {
  33. t.Parallel()
  34. got := pcParseFloat(tt.input, tt.defaultVal)
  35. if got != tt.expected {
  36. t.Fatalf("pcParseFloat(%q, %v) = %v, want %v", tt.input, tt.defaultVal, got, tt.expected)
  37. }
  38. })
  39. }
  40. }
  41. func TestPcParseInt(t *testing.T) {
  42. t.Parallel()
  43. tests := []struct {
  44. name string
  45. input string
  46. defaultVal int
  47. expected int
  48. }{
  49. {"empty string returns default", "", 30, 30},
  50. {"valid int", "10", 0, 10},
  51. {"invalid string returns default", "abc", 5, 5},
  52. {"float string returns default", "3.14", 0, 0},
  53. {"zero value", "0", 99, 0},
  54. {"negative value", "-1", 0, -1},
  55. }
  56. for _, tt := range tests {
  57. t.Run(tt.name, func(t *testing.T) {
  58. t.Parallel()
  59. got := pcParseInt(tt.input, tt.defaultVal)
  60. if got != tt.expected {
  61. t.Fatalf("pcParseInt(%q, %v) = %v, want %v", tt.input, tt.defaultVal, got, tt.expected)
  62. }
  63. })
  64. }
  65. }
  66. func TestAlipayMobilePrecreateEnvironmentOverride(t *testing.T) {
  67. svc := &PaymentConfigService{}
  68. t.Setenv(SettingAlipayMobilePrecreateDeepLink, "true")
  69. if !svc.parsePaymentConfig(map[string]string{SettingAlipayMobilePrecreateDeepLink: "false"}).AlipayMobilePrecreateDeepLink {
  70. t.Fatal("expected environment variable to enable mobile Alipay precreate")
  71. }
  72. t.Setenv(SettingAlipayMobilePrecreateDeepLink, "false")
  73. if svc.parsePaymentConfig(map[string]string{SettingAlipayMobilePrecreateDeepLink: "true"}).AlipayMobilePrecreateDeepLink {
  74. t.Fatal("expected environment variable to disable mobile Alipay precreate")
  75. }
  76. }
  77. func TestParsePaymentConfig(t *testing.T) {
  78. t.Parallel()
  79. svc := &PaymentConfigService{}
  80. t.Run("empty vals uses defaults", func(t *testing.T) {
  81. t.Parallel()
  82. cfg := svc.parsePaymentConfig(map[string]string{})
  83. if cfg.Enabled {
  84. t.Fatal("expected Enabled=false by default")
  85. }
  86. if cfg.MinAmount != 1 {
  87. t.Fatalf("expected MinAmount=1, got %v", cfg.MinAmount)
  88. }
  89. if cfg.MaxAmount != 0 {
  90. t.Fatalf("expected MaxAmount=0 (no limit), got %v", cfg.MaxAmount)
  91. }
  92. if cfg.OrderTimeoutMin != 30 {
  93. t.Fatalf("expected OrderTimeoutMin=30, got %v", cfg.OrderTimeoutMin)
  94. }
  95. if cfg.MaxPendingOrders != 3 {
  96. t.Fatalf("expected MaxPendingOrders=3, got %v", cfg.MaxPendingOrders)
  97. }
  98. if cfg.LoadBalanceStrategy != payment.DefaultLoadBalanceStrategy {
  99. t.Fatalf("expected LoadBalanceStrategy=%s, got %q", payment.DefaultLoadBalanceStrategy, cfg.LoadBalanceStrategy)
  100. }
  101. if len(cfg.EnabledTypes) != 0 {
  102. t.Fatalf("expected empty EnabledTypes, got %v", cfg.EnabledTypes)
  103. }
  104. if cfg.AlipayMobilePrecreateDeepLink {
  105. t.Fatal("expected AlipayMobilePrecreateDeepLink=false by default")
  106. }
  107. })
  108. t.Run("all values populated", func(t *testing.T) {
  109. t.Parallel()
  110. vals := map[string]string{
  111. SettingPaymentEnabled: "true",
  112. SettingMinRechargeAmount: "5.00",
  113. SettingMaxRechargeAmount: "1000.00",
  114. SettingDailyRechargeLimit: "5000.00",
  115. SettingOrderTimeoutMinutes: "15",
  116. SettingMaxPendingOrders: "5",
  117. SettingEnabledPaymentTypes: "alipay,wxpay,stripe",
  118. SettingBalancePayDisabled: "true",
  119. SettingLoadBalanceStrategy: "least_amount",
  120. SettingProductNamePrefix: "PRE",
  121. SettingProductNameSuffix: "SUF",
  122. SettingAlipayMobilePrecreateDeepLink: "true",
  123. }
  124. cfg := svc.parsePaymentConfig(vals)
  125. if !cfg.Enabled {
  126. t.Fatal("expected Enabled=true")
  127. }
  128. if cfg.MinAmount != 5 {
  129. t.Fatalf("MinAmount = %v, want 5", cfg.MinAmount)
  130. }
  131. if cfg.MaxAmount != 1000 {
  132. t.Fatalf("MaxAmount = %v, want 1000", cfg.MaxAmount)
  133. }
  134. if cfg.DailyLimit != 5000 {
  135. t.Fatalf("DailyLimit = %v, want 5000", cfg.DailyLimit)
  136. }
  137. if cfg.OrderTimeoutMin != 15 {
  138. t.Fatalf("OrderTimeoutMin = %v, want 15", cfg.OrderTimeoutMin)
  139. }
  140. if cfg.MaxPendingOrders != 5 {
  141. t.Fatalf("MaxPendingOrders = %v, want 5", cfg.MaxPendingOrders)
  142. }
  143. if len(cfg.EnabledTypes) != 3 {
  144. t.Fatalf("EnabledTypes len = %d, want 3", len(cfg.EnabledTypes))
  145. }
  146. if cfg.EnabledTypes[0] != "alipay" || cfg.EnabledTypes[1] != "wxpay" || cfg.EnabledTypes[2] != "stripe" {
  147. t.Fatalf("EnabledTypes = %v, want [alipay wxpay stripe]", cfg.EnabledTypes)
  148. }
  149. if !cfg.BalanceDisabled {
  150. t.Fatal("expected BalanceDisabled=true")
  151. }
  152. if cfg.LoadBalanceStrategy != "least_amount" {
  153. t.Fatalf("LoadBalanceStrategy = %q, want %q", cfg.LoadBalanceStrategy, "least_amount")
  154. }
  155. if cfg.ProductNamePrefix != "PRE" {
  156. t.Fatalf("ProductNamePrefix = %q, want %q", cfg.ProductNamePrefix, "PRE")
  157. }
  158. if cfg.ProductNameSuffix != "SUF" {
  159. t.Fatalf("ProductNameSuffix = %q, want %q", cfg.ProductNameSuffix, "SUF")
  160. }
  161. if !cfg.AlipayMobilePrecreateDeepLink {
  162. t.Fatal("expected AlipayMobilePrecreateDeepLink=true")
  163. }
  164. })
  165. t.Run("enabled types with spaces are trimmed", func(t *testing.T) {
  166. t.Parallel()
  167. vals := map[string]string{
  168. SettingEnabledPaymentTypes: " alipay , wxpay ",
  169. }
  170. cfg := svc.parsePaymentConfig(vals)
  171. if len(cfg.EnabledTypes) != 2 {
  172. t.Fatalf("EnabledTypes len = %d, want 2", len(cfg.EnabledTypes))
  173. }
  174. if cfg.EnabledTypes[0] != "alipay" || cfg.EnabledTypes[1] != "wxpay" {
  175. t.Fatalf("EnabledTypes = %v, want [alipay wxpay]", cfg.EnabledTypes)
  176. }
  177. })
  178. t.Run("enabled types are normalized to visible methods and deduplicated", func(t *testing.T) {
  179. t.Parallel()
  180. vals := map[string]string{
  181. SettingEnabledPaymentTypes: "alipay_direct, alipay, wxpay_direct, wxpay",
  182. }
  183. cfg := svc.parsePaymentConfig(vals)
  184. if len(cfg.EnabledTypes) != 2 {
  185. t.Fatalf("EnabledTypes len = %d, want 2", len(cfg.EnabledTypes))
  186. }
  187. if cfg.EnabledTypes[0] != "alipay" || cfg.EnabledTypes[1] != "wxpay" {
  188. t.Fatalf("EnabledTypes = %v, want [alipay wxpay]", cfg.EnabledTypes)
  189. }
  190. })
  191. t.Run("custom enabled types are preserved", func(t *testing.T) {
  192. t.Parallel()
  193. vals := map[string]string{
  194. SettingEnabledPaymentTypes: "alipay,ldc,usdt_trc20",
  195. }
  196. cfg := svc.parsePaymentConfig(vals)
  197. want := []string{"alipay", "ldc", "usdt_trc20"}
  198. if len(cfg.EnabledTypes) != len(want) {
  199. t.Fatalf("EnabledTypes len = %d, want %d (%v)", len(cfg.EnabledTypes), len(want), cfg.EnabledTypes)
  200. }
  201. for i := range want {
  202. if cfg.EnabledTypes[i] != want[i] {
  203. t.Fatalf("EnabledTypes[%d] = %q, want %q (full=%v)", i, cfg.EnabledTypes[i], want[i], cfg.EnabledTypes)
  204. }
  205. }
  206. })
  207. t.Run("empty enabled types string", func(t *testing.T) {
  208. t.Parallel()
  209. vals := map[string]string{
  210. SettingEnabledPaymentTypes: "",
  211. }
  212. cfg := svc.parsePaymentConfig(vals)
  213. if len(cfg.EnabledTypes) != 0 {
  214. t.Fatalf("expected empty EnabledTypes for empty string, got %v", cfg.EnabledTypes)
  215. }
  216. })
  217. }
  218. func TestGetBasePaymentType(t *testing.T) {
  219. t.Parallel()
  220. tests := []struct {
  221. input string
  222. expected string
  223. }{
  224. {payment.TypeEasyPay, payment.TypeEasyPay},
  225. {payment.TypeStripe, payment.TypeStripe},
  226. {payment.TypeCard, payment.TypeStripe},
  227. {payment.TypeLink, payment.TypeStripe},
  228. {payment.TypeAlipay, payment.TypeAlipay},
  229. {payment.TypeAlipayDirect, payment.TypeAlipay},
  230. {payment.TypeWxpay, payment.TypeWxpay},
  231. {payment.TypeWxpayDirect, payment.TypeWxpay},
  232. {"unknown", "unknown"},
  233. {"", ""},
  234. }
  235. for _, tt := range tests {
  236. t.Run(tt.input, func(t *testing.T) {
  237. t.Parallel()
  238. got := payment.GetBasePaymentType(tt.input)
  239. if got != tt.expected {
  240. t.Fatalf("GetBasePaymentType(%q) = %q, want %q", tt.input, got, tt.expected)
  241. }
  242. })
  243. }
  244. }
  245. func TestApplyVisibleMethodRoutingToEnabledTypes(t *testing.T) {
  246. t.Parallel()
  247. base := []string{"alipay", "wxpay", "stripe"}
  248. vals := map[string]string{
  249. SettingPaymentVisibleMethodAlipayEnabled: "true",
  250. SettingPaymentVisibleMethodAlipaySource: VisibleMethodSourceOfficialAlipay,
  251. SettingPaymentVisibleMethodWxpayEnabled: "true",
  252. SettingPaymentVisibleMethodWxpaySource: VisibleMethodSourceOfficialWechat,
  253. }
  254. available := map[string]bool{
  255. VisibleMethodSourceOfficialAlipay: true,
  256. VisibleMethodSourceOfficialWechat: false,
  257. }
  258. got := applyVisibleMethodRoutingToEnabledTypes(base, vals, available)
  259. want := []string{"alipay", "stripe"}
  260. if len(got) != len(want) {
  261. t.Fatalf("applyVisibleMethodRoutingToEnabledTypes len = %d, want %d (%v)", len(got), len(want), got)
  262. }
  263. for i := range want {
  264. if got[i] != want[i] {
  265. t.Fatalf("applyVisibleMethodRoutingToEnabledTypes[%d] = %q, want %q (full=%v)", i, got[i], want[i], got)
  266. }
  267. }
  268. }
  269. func TestApplyVisibleMethodRoutingAddsConfiguredVisibleMethod(t *testing.T) {
  270. t.Parallel()
  271. base := []string{"stripe"}
  272. vals := map[string]string{
  273. SettingPaymentVisibleMethodAlipayEnabled: "true",
  274. SettingPaymentVisibleMethodAlipaySource: VisibleMethodSourceEasyPayAlipay,
  275. }
  276. available := map[string]bool{
  277. VisibleMethodSourceEasyPayAlipay: true,
  278. }
  279. got := applyVisibleMethodRoutingToEnabledTypes(base, vals, available)
  280. want := []string{"stripe", "alipay"}
  281. if len(got) != len(want) {
  282. t.Fatalf("applyVisibleMethodRoutingToEnabledTypes len = %d, want %d (%v)", len(got), len(want), got)
  283. }
  284. for i := range want {
  285. if got[i] != want[i] {
  286. t.Fatalf("applyVisibleMethodRoutingToEnabledTypes[%d] = %q, want %q (full=%v)", i, got[i], want[i], got)
  287. }
  288. }
  289. }
  290. func TestBuildVisibleMethodSourceAvailability(t *testing.T) {
  291. t.Parallel()
  292. instances := []*dbent.PaymentProviderInstance{
  293. {ProviderKey: payment.TypeAlipay, SupportedTypes: "alipay"},
  294. {ProviderKey: payment.TypeEasyPay, SupportedTypes: "wxpay_direct, alipay"},
  295. {ProviderKey: payment.TypeWxpay, SupportedTypes: "wxpay_direct"},
  296. }
  297. got := buildVisibleMethodSourceAvailability(instances)
  298. if !got[VisibleMethodSourceOfficialAlipay] {
  299. t.Fatalf("expected %q to be available", VisibleMethodSourceOfficialAlipay)
  300. }
  301. if !got[VisibleMethodSourceEasyPayAlipay] {
  302. t.Fatalf("expected %q to be available", VisibleMethodSourceEasyPayAlipay)
  303. }
  304. if !got[VisibleMethodSourceOfficialWechat] {
  305. t.Fatalf("expected %q to be available", VisibleMethodSourceOfficialWechat)
  306. }
  307. if !got[VisibleMethodSourceEasyPayWechat] {
  308. t.Fatalf("expected %q to be available", VisibleMethodSourceEasyPayWechat)
  309. }
  310. }
  311. func TestGetPaymentConfigKeepsStoredEnabledTypes(t *testing.T) {
  312. ctx := context.Background()
  313. client := newPaymentConfigServiceTestClient(t)
  314. _, err := client.PaymentProviderInstance.Create().
  315. SetProviderKey(payment.TypeEasyPay).
  316. SetName("EasyPay Alipay").
  317. SetConfig("{}").
  318. SetSupportedTypes("alipay").
  319. SetEnabled(true).
  320. Save(ctx)
  321. if err != nil {
  322. t.Fatalf("create easypay instance: %v", err)
  323. }
  324. svc := &PaymentConfigService{
  325. entClient: client,
  326. settingRepo: &paymentConfigSettingRepoStub{
  327. values: map[string]string{
  328. SettingEnabledPaymentTypes: "alipay,wxpay,stripe",
  329. },
  330. },
  331. }
  332. cfg, err := svc.GetPaymentConfig(ctx)
  333. if err != nil {
  334. t.Fatalf("GetPaymentConfig returned error: %v", err)
  335. }
  336. want := []string{payment.TypeAlipay, payment.TypeWxpay, payment.TypeStripe}
  337. if len(cfg.EnabledTypes) != len(want) {
  338. t.Fatalf("EnabledTypes len = %d, want %d (%v)", len(cfg.EnabledTypes), len(want), cfg.EnabledTypes)
  339. }
  340. for i := range want {
  341. if cfg.EnabledTypes[i] != want[i] {
  342. t.Fatalf("EnabledTypes[%d] = %q, want %q (full=%v)", i, cfg.EnabledTypes[i], want[i], cfg.EnabledTypes)
  343. }
  344. }
  345. }
  346. func newPaymentConfigServiceTestClient(t *testing.T) *dbent.Client {
  347. t.Helper()
  348. dbName := fmt.Sprintf(
  349. "file:%s?mode=memory&cache=shared",
  350. strings.NewReplacer("/", "_", " ", "_").Replace(t.Name()),
  351. )
  352. db, err := sql.Open("sqlite", dbName)
  353. if err != nil {
  354. t.Fatalf("open sqlite: %v", err)
  355. }
  356. t.Cleanup(func() { _ = db.Close() })
  357. if _, err := db.Exec("PRAGMA foreign_keys = ON"); err != nil {
  358. t.Fatalf("enable foreign keys: %v", err)
  359. }
  360. drv := entsql.OpenDB(dialect.SQLite, db)
  361. client := enttest.NewClient(t, enttest.WithOptions(dbent.Driver(drv)))
  362. t.Cleanup(func() { _ = client.Close() })
  363. return client
  364. }
  365. type paymentConfigSettingRepoStub struct {
  366. values map[string]string
  367. updates map[string]string
  368. }
  369. func (s *paymentConfigSettingRepoStub) Get(context.Context, string) (*Setting, error) {
  370. return nil, nil
  371. }
  372. func (s *paymentConfigSettingRepoStub) GetValue(_ context.Context, key string) (string, error) {
  373. return s.values[key], nil
  374. }
  375. func (s *paymentConfigSettingRepoStub) Set(context.Context, string, string) error { return nil }
  376. func (s *paymentConfigSettingRepoStub) GetMultiple(_ context.Context, keys []string) (map[string]string, error) {
  377. out := make(map[string]string, len(keys))
  378. for _, key := range keys {
  379. out[key] = s.values[key]
  380. }
  381. return out, nil
  382. }
  383. func (s *paymentConfigSettingRepoStub) SetMultiple(_ context.Context, values map[string]string) error {
  384. s.updates = make(map[string]string, len(values))
  385. for key, value := range values {
  386. s.updates[key] = value
  387. if s.values == nil {
  388. s.values = map[string]string{}
  389. }
  390. s.values[key] = value
  391. }
  392. return nil
  393. }
  394. func (s *paymentConfigSettingRepoStub) GetAll(context.Context) (map[string]string, error) {
  395. return s.values, nil
  396. }
  397. func (s *paymentConfigSettingRepoStub) Delete(context.Context, string) error { return nil }
  398. func TestUpdatePaymentConfig_PersistsVisibleMethodRouting(t *testing.T) {
  399. repo := &paymentConfigSettingRepoStub{values: map[string]string{
  400. SettingPaymentVisibleMethodAlipayEnabled: "false",
  401. SettingPaymentVisibleMethodAlipaySource: VisibleMethodSourceOfficialAlipay,
  402. SettingPaymentVisibleMethodWxpayEnabled: "true",
  403. SettingPaymentVisibleMethodWxpaySource: VisibleMethodSourceEasyPayWechat,
  404. }}
  405. svc := &PaymentConfigService{settingRepo: repo}
  406. alipayEnabled := true
  407. wxpayEnabled := false
  408. err := svc.UpdatePaymentConfig(context.Background(), UpdatePaymentConfigRequest{
  409. VisibleMethodAlipayEnabled: &alipayEnabled,
  410. VisibleMethodAlipaySource: paymentConfigStrPtr(VisibleMethodSourceEasyPayAlipay),
  411. VisibleMethodWxpayEnabled: &wxpayEnabled,
  412. VisibleMethodWxpaySource: paymentConfigStrPtr(VisibleMethodSourceOfficialWechat),
  413. })
  414. if err != nil {
  415. t.Fatalf("UpdatePaymentConfig returned error: %v", err)
  416. }
  417. if repo.values[SettingPaymentVisibleMethodAlipayEnabled] != "true" {
  418. t.Fatalf("alipay enabled = %q, want true", repo.values[SettingPaymentVisibleMethodAlipayEnabled])
  419. }
  420. if repo.values[SettingPaymentVisibleMethodAlipaySource] != VisibleMethodSourceEasyPayAlipay {
  421. t.Fatalf("alipay source = %q, want %q", repo.values[SettingPaymentVisibleMethodAlipaySource], VisibleMethodSourceEasyPayAlipay)
  422. }
  423. if repo.values[SettingPaymentVisibleMethodWxpayEnabled] != "false" {
  424. t.Fatalf("wxpay enabled = %q, want false", repo.values[SettingPaymentVisibleMethodWxpayEnabled])
  425. }
  426. if repo.values[SettingPaymentVisibleMethodWxpaySource] != VisibleMethodSourceOfficialWechat {
  427. t.Fatalf("wxpay source = %q, want %q", repo.values[SettingPaymentVisibleMethodWxpaySource], VisibleMethodSourceOfficialWechat)
  428. }
  429. }
  430. func TestUpdatePaymentConfig_OmittedVisibleMethodRoutingIsPreserved(t *testing.T) {
  431. wantVisibleMethods := map[string]string{
  432. SettingPaymentVisibleMethodAlipayEnabled: "true",
  433. SettingPaymentVisibleMethodAlipaySource: VisibleMethodSourceEasyPayAlipay,
  434. SettingPaymentVisibleMethodWxpayEnabled: "false",
  435. SettingPaymentVisibleMethodWxpaySource: VisibleMethodSourceOfficialWechat,
  436. }
  437. initial := make(map[string]string, len(wantVisibleMethods))
  438. for key, value := range wantVisibleMethods {
  439. initial[key] = value
  440. }
  441. repo := &paymentConfigSettingRepoStub{values: initial}
  442. svc := &PaymentConfigService{settingRepo: repo}
  443. enabled := true
  444. err := svc.UpdatePaymentConfig(context.Background(), UpdatePaymentConfigRequest{Enabled: &enabled})
  445. if err != nil {
  446. t.Fatalf("UpdatePaymentConfig returned error: %v", err)
  447. }
  448. visibleMethodKeys := []string{
  449. SettingPaymentVisibleMethodAlipayEnabled,
  450. SettingPaymentVisibleMethodAlipaySource,
  451. SettingPaymentVisibleMethodWxpayEnabled,
  452. SettingPaymentVisibleMethodWxpaySource,
  453. }
  454. for _, key := range visibleMethodKeys {
  455. if _, ok := repo.updates[key]; ok {
  456. t.Fatalf("omitted visible method setting %q was written", key)
  457. }
  458. if repo.values[key] != wantVisibleMethods[key] {
  459. t.Fatalf("visible method setting %q = %q, want preserved value %q", key, repo.values[key], wantVisibleMethods[key])
  460. }
  461. }
  462. if repo.updates[SettingPaymentEnabled] != "true" {
  463. t.Fatalf("payment enabled update = %q, want true", repo.updates[SettingPaymentEnabled])
  464. }
  465. }
  466. func TestUpdatePaymentConfig_PersistsExplicitEmptyAndFalseValues(t *testing.T) {
  467. repo := &paymentConfigSettingRepoStub{values: map[string]string{
  468. SettingEnabledPaymentTypes: "alipay,wxpay",
  469. SettingBalancePayDisabled: "true",
  470. SettingProductNamePrefix: "existing",
  471. }}
  472. svc := &PaymentConfigService{settingRepo: repo}
  473. falseValue := false
  474. emptyString := ""
  475. err := svc.UpdatePaymentConfig(context.Background(), UpdatePaymentConfigRequest{
  476. EnabledTypes: []string{},
  477. BalanceDisabled: &falseValue,
  478. ProductNamePrefix: &emptyString,
  479. })
  480. if err != nil {
  481. t.Fatalf("UpdatePaymentConfig returned error: %v", err)
  482. }
  483. want := map[string]string{
  484. SettingEnabledPaymentTypes: "",
  485. SettingBalancePayDisabled: "false",
  486. SettingProductNamePrefix: "",
  487. }
  488. if len(repo.updates) != len(want) {
  489. t.Fatalf("updates = %v, want exactly %v", repo.updates, want)
  490. }
  491. for key, value := range want {
  492. if repo.updates[key] != value {
  493. t.Fatalf("update %q = %q, want %q", key, repo.updates[key], value)
  494. }
  495. if repo.values[key] != value {
  496. t.Fatalf("stored %q = %q, want %q", key, repo.values[key], value)
  497. }
  498. }
  499. }
  500. func paymentConfigStrPtr(value string) *string {
  501. return &value
  502. }