openai_image_generation_controls_test.go 30 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753
  1. package service
  2. import (
  3. "context"
  4. "encoding/json"
  5. "io"
  6. "net/http"
  7. "net/http/httptest"
  8. "strings"
  9. "testing"
  10. "time"
  11. "github.com/Wei-Shaw/sub2api/internal/config"
  12. "github.com/gin-gonic/gin"
  13. "github.com/stretchr/testify/require"
  14. "github.com/tidwall/gjson"
  15. )
  16. func TestOpenAIGatewayServiceForward_RejectsDisabledImageGenerationIntents(t *testing.T) {
  17. gin.SetMode(gin.TestMode)
  18. tests := []struct {
  19. name string
  20. body []byte
  21. }{
  22. {
  23. name: "image model",
  24. body: []byte(`{"model":"gpt-image-2","input":"draw"}`),
  25. },
  26. {
  27. name: "image tool",
  28. body: []byte(`{"model":"gpt-5.4","input":"draw","tools":[{"type":"image_generation"}]}`),
  29. },
  30. {
  31. name: "image tool choice",
  32. body: []byte(`{"model":"gpt-5.4","input":"draw","tool_choice":{"type":"image_generation"}}`),
  33. },
  34. }
  35. for _, tt := range tests {
  36. t.Run(tt.name, func(t *testing.T) {
  37. upstream := &httpUpstreamRecorder{}
  38. svc := newOpenAIImageGenerationControlTestService(upstream)
  39. c, recorder := newOpenAIImageGenerationControlTestContext(false, "unit-test-agent/1.0")
  40. account := newOpenAIImageGenerationControlTestAccount()
  41. result, err := svc.Forward(context.Background(), c, account, tt.body)
  42. require.Error(t, err)
  43. require.Nil(t, result)
  44. require.Equal(t, http.StatusForbidden, recorder.Code)
  45. require.Equal(t, "permission_error", gjson.GetBytes(recorder.Body.Bytes(), "error.type").String())
  46. require.Nil(t, upstream.lastReq, "disabled image request must not reach upstream")
  47. })
  48. }
  49. }
  50. func TestOpenAIGatewayServiceForward_DisabledGroupAllowsTextOnlyResponses(t *testing.T) {
  51. gin.SetMode(gin.TestMode)
  52. upstream := &httpUpstreamRecorder{
  53. resp: &http.Response{
  54. StatusCode: http.StatusOK,
  55. Header: http.Header{"Content-Type": []string{"application/json"}},
  56. Body: io.NopCloser(strings.NewReader(`{"id":"resp_text","model":"gpt-5.4","usage":{"input_tokens":3,"output_tokens":2}}`)),
  57. },
  58. }
  59. svc := newOpenAIImageGenerationControlTestService(upstream)
  60. c, recorder := newOpenAIImageGenerationControlTestContext(false, "unit-test-agent/1.0")
  61. account := newOpenAIImageGenerationControlTestAccount()
  62. result, err := svc.Forward(context.Background(), c, account, []byte(`{"model":"gpt-5.4","input":"write code","stream":false}`))
  63. require.NoError(t, err)
  64. require.NotNil(t, result)
  65. require.Equal(t, http.StatusOK, recorder.Code)
  66. require.Equal(t, 3, result.Usage.InputTokens)
  67. require.Equal(t, 2, result.Usage.OutputTokens)
  68. require.Equal(t, 0, result.ImageCount)
  69. require.NotNil(t, upstream.lastReq)
  70. }
  71. func TestOpenAIGatewayServiceForward_CodexImageInjectionRespectsGroupCapability(t *testing.T) {
  72. gin.SetMode(gin.TestMode)
  73. tests := []struct {
  74. name string
  75. allowImages bool
  76. bridgeEnabled bool
  77. responsesLite bool
  78. wantInjected bool
  79. }{
  80. {name: "disabled group skips injection", allowImages: false, bridgeEnabled: true, wantInjected: false},
  81. {name: "enabled group skips injection by default", allowImages: true, bridgeEnabled: false, wantInjected: false},
  82. {name: "enabled group injects image tool when bridge enabled", allowImages: true, bridgeEnabled: true, wantInjected: true},
  83. {name: "responses lite skips hosted image bridge", allowImages: true, bridgeEnabled: true, responsesLite: true, wantInjected: false},
  84. }
  85. for _, tt := range tests {
  86. t.Run(tt.name, func(t *testing.T) {
  87. upstream := &httpUpstreamRecorder{
  88. resp: &http.Response{
  89. StatusCode: http.StatusOK,
  90. Header: http.Header{"Content-Type": []string{"application/json"}},
  91. Body: io.NopCloser(strings.NewReader(`{"id":"resp_codex","model":"gpt-5.4","usage":{"input_tokens":1,"output_tokens":1}}`)),
  92. },
  93. }
  94. svc := newOpenAIImageGenerationControlTestService(upstream)
  95. svc.cfg.Gateway.CodexImageGenerationBridgeEnabled = tt.bridgeEnabled
  96. c, _ := newOpenAIImageGenerationControlTestContext(tt.allowImages, "codex_cli_rs/0.98.0")
  97. if tt.responsesLite {
  98. c.Request.Header.Set(responsesLiteHeader, "true")
  99. }
  100. account := newOpenAIImageGenerationControlTestAccount()
  101. result, err := svc.Forward(context.Background(), c, account, []byte(`{"model":"gpt-5.4","input":"write code","stream":false}`))
  102. require.NoError(t, err)
  103. require.NotNil(t, result)
  104. require.NotNil(t, upstream.lastReq)
  105. hasImageTool := gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation")`).Exists()
  106. require.Equal(t, tt.wantInjected, hasImageTool)
  107. expectedLiteHeader := ""
  108. if tt.responsesLite {
  109. expectedLiteHeader = "true"
  110. }
  111. require.Equal(t, expectedLiteHeader, upstream.lastReq.Header.Get(responsesLiteHeader))
  112. instructions := gjson.GetBytes(upstream.lastBody, "instructions").String()
  113. require.Equal(t, tt.wantInjected, strings.Contains(instructions, "image_generation"))
  114. toolChoice := gjson.GetBytes(upstream.lastBody, "tool_choice")
  115. require.Equal(t, tt.wantInjected, toolChoice.Exists())
  116. if tt.wantInjected {
  117. require.Equal(t, "auto", toolChoice.String())
  118. }
  119. })
  120. }
  121. }
  122. func TestOpenAIBuildUpstreamRequestOpenAIPassthroughForwardsResponsesLiteHeader(t *testing.T) {
  123. gin.SetMode(gin.TestMode)
  124. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.98.0")
  125. c.Request.Header.Set(responsesLiteHeader, "true")
  126. svc := newOpenAIImageGenerationControlTestService(&httpUpstreamRecorder{})
  127. req, err := svc.buildUpstreamRequestOpenAIPassthrough(
  128. c.Request.Context(),
  129. c,
  130. newOpenAIImageGenerationControlTestAccount(),
  131. []byte(`{"model":"gpt-5.4","input":"write code"}`),
  132. "test-token",
  133. )
  134. require.NoError(t, err)
  135. require.Equal(t, "true", req.Header.Get(responsesLiteHeader))
  136. }
  137. func TestOpenAIGatewayServiceForward_ExplicitImageToolWorksWithBridgeDisabled(t *testing.T) {
  138. gin.SetMode(gin.TestMode)
  139. upstream := &httpUpstreamRecorder{
  140. resp: &http.Response{
  141. StatusCode: http.StatusOK,
  142. Header: http.Header{"Content-Type": []string{"application/json"}},
  143. Body: io.NopCloser(strings.NewReader(`{"id":"resp_explicit_image","model":"gpt-5.4","usage":{"input_tokens":2,"output_tokens":1}}`)),
  144. },
  145. }
  146. svc := newOpenAIImageGenerationControlTestService(upstream)
  147. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.98.0")
  148. account := newOpenAIImageGenerationControlTestAccount()
  149. body := []byte(`{"model":"gpt-5.4","input":"draw","stream":false,"tools":[{"type":"image_generation","format":"jpeg"}]}`)
  150. result, err := svc.Forward(context.Background(), c, account, body)
  151. require.NoError(t, err)
  152. require.NotNil(t, result)
  153. require.NotNil(t, upstream.lastReq)
  154. require.True(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation")`).Exists())
  155. require.Equal(t, "jpeg", gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation").output_format`).String())
  156. require.False(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation").format`).Exists())
  157. instructions := gjson.GetBytes(upstream.lastBody, "instructions").String()
  158. require.NotContains(t, instructions, "image_generation")
  159. }
  160. func TestOpenAIGatewayServiceForward_AccountPolicyStripsExplicitImageTool(t *testing.T) {
  161. gin.SetMode(gin.TestMode)
  162. upstream := &httpUpstreamRecorder{
  163. resp: &http.Response{
  164. StatusCode: http.StatusOK,
  165. Header: http.Header{"Content-Type": []string{"application/json"}},
  166. Body: io.NopCloser(strings.NewReader(`{"id":"resp_stripped_image","model":"gpt-5.4","usage":{"input_tokens":2,"output_tokens":1}}`)),
  167. },
  168. }
  169. svc := newOpenAIImageGenerationControlTestService(upstream)
  170. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.98.0")
  171. account := newOpenAIImageGenerationControlTestAccount()
  172. account.Extra = map[string]any{
  173. featureKeyCodexImageGenerationExplicitToolPolicy: codexImageGenerationExplicitToolPolicyStrip,
  174. }
  175. body := []byte(`{
  176. "model":"gpt-5.4",
  177. "input":"draw",
  178. "stream":false,
  179. "tools":[
  180. {"type":"function","name":"shell","parameters":{"type":"object"}},
  181. {"type":"image_generation","format":"jpeg"}
  182. ],
  183. "tool_choice":{"type":"image_generation"}
  184. }`)
  185. result, err := svc.Forward(context.Background(), c, account, body)
  186. require.NoError(t, err)
  187. require.NotNil(t, result)
  188. require.NotNil(t, upstream.lastReq)
  189. require.False(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation")`).Exists())
  190. require.True(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="function")`).Exists())
  191. require.False(t, gjson.GetBytes(upstream.lastBody, "tool_choice").Exists())
  192. instructions := gjson.GetBytes(upstream.lastBody, "instructions").String()
  193. require.NotContains(t, instructions, "image_generation")
  194. }
  195. func TestOpenAIGatewayServiceForward_AccountPolicyStripsImageNamespaceTools(t *testing.T) {
  196. gin.SetMode(gin.TestMode)
  197. tests := []struct {
  198. name string
  199. passthrough bool
  200. }{
  201. {name: "managed forwarding"},
  202. {name: "passthrough forwarding", passthrough: true},
  203. }
  204. for _, tt := range tests {
  205. t.Run(tt.name, func(t *testing.T) {
  206. upstream := &httpUpstreamRecorder{
  207. resp: &http.Response{
  208. StatusCode: http.StatusOK,
  209. Header: http.Header{"Content-Type": []string{"application/json"}},
  210. Body: io.NopCloser(strings.NewReader(`{"id":"resp_stripped_namespace","model":"gpt-5.5","usage":{"input_tokens":2,"output_tokens":1}}`)),
  211. },
  212. }
  213. svc := newOpenAIImageGenerationControlTestService(upstream)
  214. c, _ := newOpenAIImageGenerationControlTestContext(false, "codex_cli_rs/0.144.1")
  215. SetOpenAIClientTransport(c, OpenAIClientTransportHTTP)
  216. account := newOpenAIImageGenerationControlTestAccount()
  217. account.Extra = map[string]any{
  218. featureKeyCodexImageGenerationExplicitToolPolicy: codexImageGenerationExplicitToolPolicyStrip,
  219. "openai_passthrough": tt.passthrough,
  220. }
  221. body := []byte(`{
  222. "model":"gpt-5.5",
  223. "stream":false,
  224. "tools":[
  225. {"type":"function","name":"shell","parameters":{"type":"object"}},
  226. {"type":"namespace","name":"image_gen","tools":[{"type":"function","name":"imagegen"}]},
  227. {"type":"namespace","name":"code_tools","tools":[{"type":"function","name":"run"}]}
  228. ],
  229. "input":[
  230. {"type":"message","role":"user","content":[{"type":"input_text","text":"write code"}]},
  231. {"type":"additional_tools","tools":[{"type":"namespace","name":"image_gen","tools":[{"type":"function","name":"imagegen"}]}]}
  232. ],
  233. "tool_choice":"auto"
  234. }`)
  235. result, err := svc.Forward(context.Background(), c, account, body)
  236. require.NoError(t, err)
  237. require.NotNil(t, result)
  238. require.NotNil(t, upstream.lastReq)
  239. var forwarded map[string]any
  240. require.NoError(t, json.Unmarshal(upstream.lastBody, &forwarded))
  241. require.False(t, hasOpenAIImageGenerationTool(forwarded))
  242. require.Equal(t, "auto", forwarded["tool_choice"])
  243. require.True(t, gjson.GetBytes(upstream.lastBody, `tools.#(name=="shell")`).Exists())
  244. require.True(t, gjson.GetBytes(upstream.lastBody, `tools.#(name=="code_tools")`).Exists())
  245. require.Equal(t, "write code", gjson.GetBytes(upstream.lastBody, "input.0.content.0.text").String())
  246. cached, known := getOpenAIImageIntentHint(c)
  247. require.True(t, known)
  248. require.True(t, cached)
  249. })
  250. }
  251. }
  252. func TestOpenAIGatewayServiceForward_ChannelBridgeOverrideEnablesCodexInjection(t *testing.T) {
  253. gin.SetMode(gin.TestMode)
  254. upstream := &httpUpstreamRecorder{
  255. resp: &http.Response{
  256. StatusCode: http.StatusOK,
  257. Header: http.Header{"Content-Type": []string{"application/json"}},
  258. Body: io.NopCloser(strings.NewReader(`{"id":"resp_channel_bridge","model":"gpt-5.4","usage":{"input_tokens":1,"output_tokens":1}}`)),
  259. },
  260. }
  261. svc := newOpenAIImageGenerationControlTestService(upstream)
  262. groupID := int64(4242)
  263. svc.channelService = newOpenAIImageGenerationControlChannelService(groupID, &Channel{
  264. ID: 9001,
  265. Status: StatusActive,
  266. FeaturesConfig: map[string]any{
  267. featureKeyCodexImageGenerationBridge: map[string]any{PlatformOpenAI: true},
  268. },
  269. })
  270. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.98.0")
  271. account := newOpenAIImageGenerationControlTestAccount()
  272. result, err := svc.Forward(context.Background(), c, account, []byte(`{"model":"gpt-5.4","input":"write code","stream":false}`))
  273. require.NoError(t, err)
  274. require.NotNil(t, result)
  275. require.NotNil(t, upstream.lastReq)
  276. require.True(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation")`).Exists())
  277. require.Equal(t, "auto", gjson.GetBytes(upstream.lastBody, "tool_choice").String())
  278. instructions := gjson.GetBytes(upstream.lastBody, "instructions").String()
  279. require.Contains(t, instructions, "image_generation")
  280. }
  281. func TestOpenAIGatewayServiceForward_CodexBridgeDoesNotInjectHostedToolAlongsideImageGenNamespace(t *testing.T) {
  282. gin.SetMode(gin.TestMode)
  283. upstream := &httpUpstreamRecorder{
  284. resp: &http.Response{
  285. StatusCode: http.StatusOK,
  286. Header: http.Header{"Content-Type": []string{"application/json"}},
  287. Body: io.NopCloser(strings.NewReader(`{"id":"resp_namespace_image","model":"gpt-5.5","usage":{"input_tokens":1,"output_tokens":1}}`)),
  288. },
  289. }
  290. svc := newOpenAIImageGenerationControlTestService(upstream)
  291. svc.cfg.Gateway.CodexImageGenerationBridgeEnabled = true
  292. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.144.1")
  293. account := newOpenAIImageGenerationControlTestAccount()
  294. body := []byte(`{
  295. "model":"gpt-5.5",
  296. "stream":false,
  297. "tools":[
  298. {"type":"function","name":"shell","parameters":{"type":"object"}},
  299. {"type":"namespace","name":"image_gen","tools":[{"type":"function","name":"imagegen"}]}
  300. ],
  301. "input":[
  302. {"type":"message","role":"user","content":[{"type":"input_text","text":"draw a cat"}]},
  303. {"type":"additional_tools","tools":[{"type":"namespace","name":"image_gen","tools":[{"type":"function","name":"imagegen"}]}]}
  304. ],
  305. "tool_choice":"auto"
  306. }`)
  307. result, err := svc.Forward(context.Background(), c, account, body)
  308. require.NoError(t, err)
  309. require.NotNil(t, result)
  310. require.NotNil(t, upstream.lastReq)
  311. require.False(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation")`).Exists())
  312. require.Equal(t, "namespace", gjson.GetBytes(upstream.lastBody, `tools.#(name=="image_gen").type`).String())
  313. require.Equal(t, "namespace", gjson.GetBytes(upstream.lastBody, `input.#(type=="additional_tools").tools.#(name=="image_gen").type`).String())
  314. }
  315. func TestOpenAIGatewayServiceForward_CodexBridgePreservesImageGenFunction(t *testing.T) {
  316. gin.SetMode(gin.TestMode)
  317. tests := []struct {
  318. name string
  319. tool string
  320. }{
  321. {
  322. name: "flat function",
  323. tool: `{"type":"function","name":"image_gen.imagegen","parameters":{"type":"object"}}`,
  324. },
  325. {
  326. name: "nested function",
  327. tool: `{"type":"function","function":{"name":"image_gen.imagegen","parameters":{"type":"object"}}}`,
  328. },
  329. }
  330. for _, tt := range tests {
  331. t.Run(tt.name, func(t *testing.T) {
  332. upstream := &httpUpstreamRecorder{
  333. resp: &http.Response{
  334. StatusCode: http.StatusOK,
  335. Header: http.Header{"Content-Type": []string{"application/json"}},
  336. Body: io.NopCloser(strings.NewReader(`{"id":"resp_function_image","model":"gpt-5.5","usage":{"input_tokens":1,"output_tokens":1}}`)),
  337. },
  338. }
  339. svc := newOpenAIImageGenerationControlTestService(upstream)
  340. svc.cfg.Gateway.CodexImageGenerationBridgeEnabled = true
  341. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.144.1")
  342. account := newOpenAIImageGenerationControlTestAccount()
  343. body := []byte(`{"model":"gpt-5.5","input":"draw a cat","stream":false,"tools":[` + tt.tool + `]}`)
  344. result, err := svc.Forward(context.Background(), c, account, body)
  345. require.NoError(t, err)
  346. require.NotNil(t, result)
  347. require.NotNil(t, upstream.lastReq)
  348. var forwarded map[string]any
  349. require.NoError(t, json.Unmarshal(upstream.lastBody, &forwarded))
  350. require.True(t, hasCodexImageGenerationFunctionTool(forwarded))
  351. require.False(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation")`).Exists())
  352. require.False(t, gjson.GetBytes(upstream.lastBody, "tool_choice").Exists())
  353. require.NotContains(t, gjson.GetBytes(upstream.lastBody, "instructions").String(), codexImageGenerationBridgeMarker)
  354. })
  355. }
  356. }
  357. func TestOpenAIGatewayServiceForward_CodexBridgePreservesExistingToolChoice(t *testing.T) {
  358. gin.SetMode(gin.TestMode)
  359. upstream := &httpUpstreamRecorder{
  360. resp: &http.Response{
  361. StatusCode: http.StatusOK,
  362. Header: http.Header{"Content-Type": []string{"application/json"}},
  363. Body: io.NopCloser(strings.NewReader(`{"id":"resp_codex_tool_choice","model":"gpt-5.4","usage":{"input_tokens":1,"output_tokens":1}}`)),
  364. },
  365. }
  366. svc := newOpenAIImageGenerationControlTestService(upstream)
  367. svc.cfg.Gateway.CodexImageGenerationBridgeEnabled = true
  368. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.98.0")
  369. account := newOpenAIImageGenerationControlTestAccount()
  370. result, err := svc.Forward(context.Background(), c, account, []byte(`{"model":"gpt-5.4","input":"draw","stream":false,"tools":[{"type":"image_generation"}],"tool_choice":{"type":"image_generation"}}`))
  371. require.NoError(t, err)
  372. require.NotNil(t, result)
  373. require.NotNil(t, upstream.lastReq)
  374. require.Equal(t, "image_generation", gjson.GetBytes(upstream.lastBody, "tool_choice.type").String())
  375. }
  376. func TestOpenAIGatewayServiceForward_CodexBridgeSkipsCompactRequests(t *testing.T) {
  377. gin.SetMode(gin.TestMode)
  378. upstream := &httpUpstreamRecorder{
  379. resp: &http.Response{
  380. StatusCode: http.StatusOK,
  381. Header: http.Header{"Content-Type": []string{"application/json"}},
  382. Body: io.NopCloser(strings.NewReader(`{"id":"resp_codex_compact","model":"gpt-5.4","usage":{"input_tokens":1,"output_tokens":1}}`)),
  383. },
  384. }
  385. svc := newOpenAIImageGenerationControlTestService(upstream)
  386. svc.cfg.Gateway.CodexImageGenerationBridgeEnabled = true
  387. c, _ := newOpenAIImageGenerationControlTestContext(true, "codex_cli_rs/0.98.0")
  388. c.Request = httptest.NewRequest(http.MethodPost, "/openai/v1/responses/compact", nil)
  389. c.Request.Header.Set("User-Agent", "codex_cli_rs/0.98.0")
  390. account := newOpenAIImageGenerationControlTestAccount()
  391. // /responses/compact 上游不接受 tool_choice,bridge 注入必须整体豁免 compact 请求。
  392. result, err := svc.Forward(context.Background(), c, account, []byte(`{"model":"gpt-5.4","input":"summarize the conversation","stream":false}`))
  393. require.NoError(t, err)
  394. require.NotNil(t, result)
  395. require.NotNil(t, upstream.lastReq)
  396. require.False(t, gjson.GetBytes(upstream.lastBody, "tool_choice").Exists())
  397. require.False(t, gjson.GetBytes(upstream.lastBody, `tools.#(type=="image_generation")`).Exists())
  398. instructions := gjson.GetBytes(upstream.lastBody, "instructions").String()
  399. require.NotContains(t, instructions, "image_generation")
  400. }
  401. func TestOpenAIGatewayService_CodexImageGenerationBridgeOverridePrecedence(t *testing.T) {
  402. groupID := int64(4242)
  403. tests := []struct {
  404. name string
  405. global bool
  406. channel *Channel
  407. account *Account
  408. want bool
  409. }{
  410. {
  411. name: "global default enables bridge",
  412. global: true,
  413. account: &Account{
  414. Platform: PlatformOpenAI,
  415. },
  416. want: true,
  417. },
  418. {
  419. name: "channel true overrides disabled global",
  420. global: false,
  421. channel: &Channel{ID: 1, Status: StatusActive, FeaturesConfig: map[string]any{
  422. featureKeyCodexImageGenerationBridge: map[string]any{PlatformOpenAI: true},
  423. }},
  424. account: &Account{Platform: PlatformOpenAI},
  425. want: true,
  426. },
  427. {
  428. name: "channel false overrides enabled global",
  429. global: true,
  430. channel: &Channel{ID: 1, Status: StatusActive, FeaturesConfig: map[string]any{
  431. featureKeyCodexImageGenerationBridge: map[string]any{PlatformOpenAI: false},
  432. }},
  433. account: &Account{Platform: PlatformOpenAI},
  434. want: false,
  435. },
  436. {
  437. name: "account false overrides channel and global true",
  438. global: true,
  439. channel: &Channel{ID: 1, Status: StatusActive, FeaturesConfig: map[string]any{
  440. featureKeyCodexImageGenerationBridge: map[string]any{PlatformOpenAI: true},
  441. }},
  442. account: &Account{
  443. Platform: PlatformOpenAI,
  444. Extra: map[string]any{featureKeyCodexImageGenerationBridge: false},
  445. },
  446. want: false,
  447. },
  448. {
  449. name: "nested account true overrides channel false",
  450. global: false,
  451. channel: &Channel{ID: 1, Status: StatusActive, FeaturesConfig: map[string]any{
  452. featureKeyCodexImageGenerationBridge: map[string]any{PlatformOpenAI: false},
  453. }},
  454. account: &Account{
  455. Platform: PlatformOpenAI,
  456. Extra: map[string]any{
  457. PlatformOpenAI: map[string]any{"codex_image_generation_bridge_enabled": true},
  458. },
  459. },
  460. want: true,
  461. },
  462. {
  463. name: "non openai account extra is ignored",
  464. global: false,
  465. account: &Account{
  466. Platform: PlatformAnthropic,
  467. Extra: map[string]any{featureKeyCodexImageGenerationBridge: true},
  468. },
  469. want: false,
  470. },
  471. }
  472. for _, tt := range tests {
  473. t.Run(tt.name, func(t *testing.T) {
  474. svc := newOpenAIImageGenerationControlTestService(&httpUpstreamRecorder{})
  475. svc.cfg.Gateway.CodexImageGenerationBridgeEnabled = tt.global
  476. if tt.channel != nil {
  477. svc.channelService = newOpenAIImageGenerationControlChannelService(groupID, tt.channel)
  478. }
  479. apiKey := &APIKey{GroupID: &groupID}
  480. got := svc.isCodexImageGenerationBridgeEnabled(context.Background(), tt.account, apiKey)
  481. require.Equal(t, tt.want, got)
  482. })
  483. }
  484. }
  485. func TestOpenAIGatewayServiceHandleResponsesImageOutputs_NonStreaming(t *testing.T) {
  486. gin.SetMode(gin.TestMode)
  487. svc := newOpenAIImageGenerationControlTestService(&httpUpstreamRecorder{})
  488. c, _ := newOpenAIImageGenerationControlTestContext(true, "unit-test-agent/1.0")
  489. resp := &http.Response{
  490. StatusCode: http.StatusOK,
  491. Header: http.Header{"Content-Type": []string{"application/json"}},
  492. Body: io.NopCloser(strings.NewReader(`{
  493. "id":"resp_image_json",
  494. "model":"gpt-5.4",
  495. "output":[{"id":"ig_json_1","type":"image_generation_call","result":"final-image"}],
  496. "usage":{"input_tokens":7,"output_tokens":3,"output_tokens_details":{"image_tokens":2}}
  497. }`)),
  498. }
  499. result, err := svc.handleNonStreamingResponse(context.Background(), resp, c, &Account{ID: 1, Type: AccountTypeAPIKey}, "gpt-5.4", "gpt-5.4")
  500. require.NoError(t, err)
  501. require.NotNil(t, result)
  502. require.Equal(t, 1, result.imageCount)
  503. require.NotNil(t, result.usage)
  504. require.Equal(t, 7, result.usage.InputTokens)
  505. require.Equal(t, 3, result.usage.OutputTokens)
  506. require.Equal(t, 2, result.usage.ImageOutputTokens)
  507. }
  508. func TestOpenAIGatewayServiceHandleResponsesImageOutputs_Streaming(t *testing.T) {
  509. gin.SetMode(gin.TestMode)
  510. svc := newOpenAIImageGenerationControlTestService(&httpUpstreamRecorder{})
  511. c, recorder := newOpenAIImageGenerationControlTestContext(true, "unit-test-agent/1.0")
  512. resp := &http.Response{
  513. StatusCode: http.StatusOK,
  514. Header: http.Header{"Content-Type": []string{"text/event-stream"}},
  515. Body: io.NopCloser(strings.NewReader(
  516. "data: {\"type\":\"response.output_item.done\",\"item\":{\"id\":\"ig_stream_1\",\"type\":\"image_generation_call\",\"status\":\"generating\",\"result\":\"final-image\"}}\n\n" +
  517. "data: {\"type\":\"response.completed\",\"response\":{\"id\":\"resp_image_stream\",\"model\":\"gpt-5.5\",\"output\":[{\"id\":\"ig_stream_1\",\"type\":\"image_generation_call\",\"status\":\"generating\",\"result\":\"final-image\"}],\"usage\":{\"input_tokens\":11,\"output_tokens\":5,\"output_tokens_details\":{\"image_tokens\":4}}}}\n\n",
  518. )),
  519. }
  520. result, err := svc.handleStreamingResponse(context.Background(), resp, c, &Account{ID: 1}, time.Now(), "gpt-5.5", "gpt-5.5")
  521. require.NoError(t, err)
  522. require.NotNil(t, result)
  523. require.Equal(t, 1, result.imageCount)
  524. require.NotNil(t, result.usage)
  525. require.Equal(t, 11, result.usage.InputTokens)
  526. require.Equal(t, 5, result.usage.OutputTokens)
  527. require.Equal(t, 4, result.usage.ImageOutputTokens)
  528. require.NotContains(t, recorder.Body.String(), `"status":"generating"`)
  529. require.Equal(t, 2, strings.Count(recorder.Body.String(), `"status":"completed"`))
  530. }
  531. func TestOpenAIGatewayServiceHandleResponsesImageOutputs_StreamingPassthrough(t *testing.T) {
  532. gin.SetMode(gin.TestMode)
  533. svc := newOpenAIImageGenerationControlTestService(&httpUpstreamRecorder{})
  534. c, recorder := newOpenAIImageGenerationControlTestContext(true, "unit-test-agent/1.0")
  535. resp := &http.Response{
  536. StatusCode: http.StatusOK,
  537. Header: http.Header{"Content-Type": []string{"text/event-stream"}},
  538. Body: io.NopCloser(strings.NewReader(
  539. "data: {\"type\":\"response.output_item.done\",\"item\":{\"id\":\"ig_stream_1\",\"type\":\"image_generation_call\",\"status\":\"in_progress\",\"result\":\"final-image\"}}\n\n" +
  540. "data: {\"type\":\"response.completed\",\"response\":{\"id\":\"resp_image_stream\",\"model\":\"gpt-5.5\",\"output\":[{\"id\":\"ig_stream_1\",\"type\":\"image_generation_call\",\"status\":\"in_progress\",\"result\":\"final-image\"}],\"usage\":{\"input_tokens\":11,\"output_tokens\":5,\"output_tokens_details\":{\"image_tokens\":4}}}}\n\n",
  541. )),
  542. }
  543. result, err := svc.handleStreamingResponsePassthrough(context.Background(), resp, c, &Account{ID: 1}, time.Now(), "gpt-5.5", "gpt-5.5")
  544. require.NoError(t, err)
  545. require.NotNil(t, result)
  546. require.NotContains(t, recorder.Body.String(), `"status":"in_progress"`)
  547. require.Equal(t, 2, strings.Count(recorder.Body.String(), `"status":"completed"`))
  548. }
  549. func TestNormalizeCompletedImageGenerationStatus(t *testing.T) {
  550. tests := []struct {
  551. name string
  552. input string
  553. want string
  554. wantChanged bool
  555. }{
  556. {
  557. name: "output item done with result",
  558. input: `{"type":"response.output_item.done","item":{"type":"image_generation_call","status":"generating","result":"image-data"}}`,
  559. want: `{"type":"response.output_item.done","item":{"type":"image_generation_call","status":"completed","result":"image-data"}}`,
  560. wantChanged: true,
  561. },
  562. {
  563. name: "terminal response only changes completed image result",
  564. input: `{"type":"response.completed","response":{"output":[{"type":"image_generation_call","status":"in_progress","result":"image-data"},{"type":"image_generation_call","status":"failed","result":"partial-data"}]}}`,
  565. want: `{"type":"response.completed","response":{"output":[{"type":"image_generation_call","status":"completed","result":"image-data"},{"type":"image_generation_call","status":"failed","result":"partial-data"}]}}`,
  566. wantChanged: true,
  567. },
  568. {
  569. name: "done item without result",
  570. input: `{"type":"response.output_item.done","item":{"type":"image_generation_call","status":"generating"}}`,
  571. want: `{"type":"response.output_item.done","item":{"type":"image_generation_call","status":"generating"}}`,
  572. wantChanged: false,
  573. },
  574. {
  575. name: "non-final image event",
  576. input: `{"type":"response.output_item.added","item":{"type":"image_generation_call","status":"generating","result":"image-data"}}`,
  577. want: `{"type":"response.output_item.added","item":{"type":"image_generation_call","status":"generating","result":"image-data"}}`,
  578. wantChanged: false,
  579. },
  580. {
  581. name: "done preserves base64 result",
  582. input: `{"type":"response.done","response":{"output":[{"type":"image_generation_call","status":"generating","result":"iVBORw0KGgoAAAANSUhEUg/+=="}]}}`,
  583. want: `{"type":"response.done","response":{"output":[{"type":"image_generation_call","status":"completed","result":"iVBORw0KGgoAAAANSUhEUg/+=="}]}}`,
  584. wantChanged: true,
  585. },
  586. }
  587. for _, tt := range tests {
  588. t.Run(tt.name, func(t *testing.T) {
  589. got, changed := normalizeCompletedImageGenerationStatus([]byte(tt.input))
  590. require.Equal(t, tt.wantChanged, changed)
  591. require.JSONEq(t, tt.want, string(got))
  592. })
  593. }
  594. }
  595. // TestHandleStreamingResponse_CyberPolicyCapturesRealUpstreamTokens 锁定流式
  596. // /v1/responses 命中 cyber_policy 的计费正确性:response.failed 自带的真实 usage
  597. // 必须在打 cyber 标记前被解析进 mark;否则计费走 mark.UpstreamInTok 会按 0 token
  598. // 漏记真实用量(该路径返回错误,handler 仅经 RecordCyberPolicyUsageLog 计费)。
  599. func TestHandleStreamingResponse_CyberPolicyCapturesRealUpstreamTokens(t *testing.T) {
  600. gin.SetMode(gin.TestMode)
  601. svc := newOpenAIImageGenerationControlTestService(&httpUpstreamRecorder{})
  602. c, _ := newOpenAIImageGenerationControlTestContext(false, "unit-test-agent/1.0")
  603. resp := &http.Response{
  604. StatusCode: http.StatusOK,
  605. Header: http.Header{"Content-Type": []string{"text/event-stream"}},
  606. Body: io.NopCloser(strings.NewReader(
  607. "data: {\"type\":\"response.created\",\"response\":{\"id\":\"resp_cyber\"}}\n\n" +
  608. "data: {\"type\":\"response.failed\",\"response\":{\"id\":\"resp_cyber\",\"error\":{\"code\":\"cyber_policy\",\"message\":\"blocked by network policy\"},\"usage\":{\"input_tokens\":1234,\"output_tokens\":7}}}\n\n",
  609. )),
  610. }
  611. _, err := svc.handleStreamingResponse(context.Background(), resp, c, &Account{ID: 1}, time.Now(), "gpt-5.5", "gpt-5.5")
  612. require.Error(t, err, "cyber 命中的流式响应应返回错误(sawFailedEvent)")
  613. mark := GetOpsCyberPolicy(c)
  614. require.NotNil(t, mark, "必须打上 cyber 标记")
  615. require.Equal(t, "cyber_policy", mark.Code)
  616. require.Equal(t, 1234, mark.UpstreamInTok, "必须捕获 response.failed 自带真实 input token,而非解析前的 0")
  617. require.Equal(t, 7, mark.UpstreamOutTok)
  618. }
  619. func newOpenAIImageGenerationControlTestService(upstream *httpUpstreamRecorder) *OpenAIGatewayService {
  620. cfg := &config.Config{}
  621. return &OpenAIGatewayService{
  622. cfg: cfg,
  623. httpUpstream: upstream,
  624. cache: &stubGatewayCache{},
  625. openaiWSResolver: NewOpenAIWSProtocolResolver(cfg),
  626. toolCorrector: NewCodexToolCorrector(),
  627. }
  628. }
  629. func newOpenAIImageGenerationControlChannelService(groupID int64, ch *Channel) *ChannelService {
  630. svc := &ChannelService{}
  631. cache := newEmptyChannelCache()
  632. if ch != nil {
  633. cache.channelByGroupID[groupID] = ch
  634. cache.byID[ch.ID] = ch
  635. }
  636. cache.loadedAt = time.Now()
  637. svc.cache.Store(cache)
  638. return svc
  639. }
  640. func newOpenAIImageGenerationControlTestContext(allowImages bool, userAgent string) (*gin.Context, *httptest.ResponseRecorder) {
  641. recorder := httptest.NewRecorder()
  642. c, _ := gin.CreateTestContext(recorder)
  643. c.Request = httptest.NewRequest(http.MethodPost, "/openai/v1/responses", nil)
  644. c.Request.Header.Set("User-Agent", userAgent)
  645. groupID := int64(4242)
  646. c.Set("api_key", &APIKey{
  647. ID: 2424,
  648. GroupID: &groupID,
  649. Group: &Group{
  650. ID: groupID,
  651. AllowImageGeneration: allowImages,
  652. RateMultiplier: 1,
  653. ImageRateMultiplier: 1,
  654. },
  655. })
  656. return c, recorder
  657. }
  658. func newOpenAIImageGenerationControlTestAccount() *Account {
  659. return &Account{
  660. ID: 5151,
  661. Name: "openai-image-controls",
  662. Platform: PlatformOpenAI,
  663. Type: AccountTypeAPIKey,
  664. Status: StatusActive,
  665. Schedulable: true,
  666. Concurrency: 1,
  667. Credentials: map[string]any{
  668. "api_key": "sk-test",
  669. },
  670. }
  671. }