apikey_handler_test.go 7.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242
  1. package admin
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "net/http"
  8. "net/http/httptest"
  9. "testing"
  10. "time"
  11. infraerrors "github.com/Wei-Shaw/sub2api/internal/pkg/errors"
  12. "github.com/Wei-Shaw/sub2api/internal/service"
  13. "github.com/gin-gonic/gin"
  14. "github.com/stretchr/testify/require"
  15. )
  16. func setupAPIKeyHandler(adminSvc service.AdminService) *gin.Engine {
  17. gin.SetMode(gin.TestMode)
  18. router := gin.New()
  19. h := NewAdminAPIKeyHandler(adminSvc)
  20. router.PUT("/api/v1/admin/api-keys/:id", h.UpdateGroup)
  21. return router
  22. }
  23. func TestAdminAPIKeyHandler_UpdateGroup_InvalidID(t *testing.T) {
  24. router := setupAPIKeyHandler(newStubAdminService())
  25. body := `{"group_id": 2}`
  26. rec := httptest.NewRecorder()
  27. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/abc", bytes.NewBufferString(body))
  28. req.Header.Set("Content-Type", "application/json")
  29. router.ServeHTTP(rec, req)
  30. require.Equal(t, http.StatusBadRequest, rec.Code)
  31. require.Contains(t, rec.Body.String(), "Invalid API key ID")
  32. }
  33. func TestAdminAPIKeyHandler_UpdateGroup_InvalidJSON(t *testing.T) {
  34. router := setupAPIKeyHandler(newStubAdminService())
  35. rec := httptest.NewRecorder()
  36. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(`{bad json`))
  37. req.Header.Set("Content-Type", "application/json")
  38. router.ServeHTTP(rec, req)
  39. require.Equal(t, http.StatusBadRequest, rec.Code)
  40. require.Contains(t, rec.Body.String(), "Invalid request")
  41. }
  42. func TestAdminAPIKeyHandler_UpdateGroup_KeyNotFound(t *testing.T) {
  43. router := setupAPIKeyHandler(newStubAdminService())
  44. body := `{"group_id": 2}`
  45. rec := httptest.NewRecorder()
  46. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/999", bytes.NewBufferString(body))
  47. req.Header.Set("Content-Type", "application/json")
  48. router.ServeHTTP(rec, req)
  49. // ErrAPIKeyNotFound maps to 404
  50. require.Equal(t, http.StatusNotFound, rec.Code)
  51. }
  52. func TestAdminAPIKeyHandler_UpdateGroup_BindGroup(t *testing.T) {
  53. router := setupAPIKeyHandler(newStubAdminService())
  54. body := `{"group_id": 2}`
  55. rec := httptest.NewRecorder()
  56. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(body))
  57. req.Header.Set("Content-Type", "application/json")
  58. router.ServeHTTP(rec, req)
  59. require.Equal(t, http.StatusOK, rec.Code)
  60. var resp struct {
  61. Code int `json:"code"`
  62. Data json.RawMessage `json:"data"`
  63. }
  64. require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &resp))
  65. require.Equal(t, 0, resp.Code)
  66. var data struct {
  67. APIKey struct {
  68. ID int64 `json:"id"`
  69. GroupID *int64 `json:"group_id"`
  70. } `json:"api_key"`
  71. AutoGrantedGroupAccess bool `json:"auto_granted_group_access"`
  72. }
  73. require.NoError(t, json.Unmarshal(resp.Data, &data))
  74. require.Equal(t, int64(10), data.APIKey.ID)
  75. require.NotNil(t, data.APIKey.GroupID)
  76. require.Equal(t, int64(2), *data.APIKey.GroupID)
  77. }
  78. func TestAdminAPIKeyHandler_UpdateGroup_Unbind(t *testing.T) {
  79. svc := newStubAdminService()
  80. gid := int64(2)
  81. svc.apiKeys[0].GroupID = &gid
  82. router := setupAPIKeyHandler(svc)
  83. body := `{"group_id": 0}`
  84. rec := httptest.NewRecorder()
  85. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(body))
  86. req.Header.Set("Content-Type", "application/json")
  87. router.ServeHTTP(rec, req)
  88. require.Equal(t, http.StatusOK, rec.Code)
  89. var resp struct {
  90. Data struct {
  91. APIKey struct {
  92. GroupID *int64 `json:"group_id"`
  93. } `json:"api_key"`
  94. } `json:"data"`
  95. }
  96. require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &resp))
  97. require.Nil(t, resp.Data.APIKey.GroupID)
  98. }
  99. func TestAdminAPIKeyHandler_ResetRateLimitUsage(t *testing.T) {
  100. svc := newStubAdminService()
  101. now := time.Now()
  102. svc.apiKeys[0].Usage5h = 1.2
  103. svc.apiKeys[0].Usage1d = 3.4
  104. svc.apiKeys[0].Usage7d = 5.6
  105. svc.apiKeys[0].Window5hStart = &now
  106. svc.apiKeys[0].Window1dStart = &now
  107. svc.apiKeys[0].Window7dStart = &now
  108. router := setupAPIKeyHandler(svc)
  109. rec := httptest.NewRecorder()
  110. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(`{"reset_rate_limit_usage":true}`))
  111. req.Header.Set("Content-Type", "application/json")
  112. router.ServeHTTP(rec, req)
  113. require.Equal(t, http.StatusOK, rec.Code)
  114. var resp struct {
  115. Data struct {
  116. APIKey struct {
  117. Usage5h float64 `json:"usage_5h"`
  118. Usage1d float64 `json:"usage_1d"`
  119. Usage7d float64 `json:"usage_7d"`
  120. Window5hStart *time.Time `json:"window_5h_start"`
  121. Window1dStart *time.Time `json:"window_1d_start"`
  122. Window7dStart *time.Time `json:"window_7d_start"`
  123. } `json:"api_key"`
  124. } `json:"data"`
  125. }
  126. require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &resp))
  127. require.Zero(t, resp.Data.APIKey.Usage5h)
  128. require.Zero(t, resp.Data.APIKey.Usage1d)
  129. require.Zero(t, resp.Data.APIKey.Usage7d)
  130. require.Nil(t, resp.Data.APIKey.Window5hStart)
  131. require.Nil(t, resp.Data.APIKey.Window1dStart)
  132. require.Nil(t, resp.Data.APIKey.Window7dStart)
  133. }
  134. func TestAdminAPIKeyHandler_UpdateGroup_ServiceError(t *testing.T) {
  135. svc := &failingUpdateGroupService{
  136. stubAdminService: newStubAdminService(),
  137. err: errors.New("internal failure"),
  138. }
  139. router := setupAPIKeyHandler(svc)
  140. body := `{"group_id": 2}`
  141. rec := httptest.NewRecorder()
  142. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(body))
  143. req.Header.Set("Content-Type", "application/json")
  144. router.ServeHTTP(rec, req)
  145. require.Equal(t, http.StatusInternalServerError, rec.Code)
  146. }
  147. // H2: empty body → group_id is nil → no-op, returns original key
  148. func TestAdminAPIKeyHandler_UpdateGroup_EmptyBody_NoChange(t *testing.T) {
  149. router := setupAPIKeyHandler(newStubAdminService())
  150. rec := httptest.NewRecorder()
  151. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(`{}`))
  152. req.Header.Set("Content-Type", "application/json")
  153. router.ServeHTTP(rec, req)
  154. require.Equal(t, http.StatusOK, rec.Code)
  155. var resp struct {
  156. Code int `json:"code"`
  157. Data struct {
  158. APIKey struct {
  159. ID int64 `json:"id"`
  160. } `json:"api_key"`
  161. } `json:"data"`
  162. }
  163. require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &resp))
  164. require.Equal(t, 0, resp.Code)
  165. require.Equal(t, int64(10), resp.Data.APIKey.ID)
  166. }
  167. // M2: service returns GROUP_NOT_ACTIVE → handler maps to 400
  168. func TestAdminAPIKeyHandler_UpdateGroup_GroupNotActive(t *testing.T) {
  169. svc := &failingUpdateGroupService{
  170. stubAdminService: newStubAdminService(),
  171. err: infraerrors.BadRequest("GROUP_NOT_ACTIVE", "target group is not active"),
  172. }
  173. router := setupAPIKeyHandler(svc)
  174. rec := httptest.NewRecorder()
  175. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(`{"group_id": 5}`))
  176. req.Header.Set("Content-Type", "application/json")
  177. router.ServeHTTP(rec, req)
  178. require.Equal(t, http.StatusBadRequest, rec.Code)
  179. require.Contains(t, rec.Body.String(), "GROUP_NOT_ACTIVE")
  180. }
  181. // M2: service returns INVALID_GROUP_ID → handler maps to 400
  182. func TestAdminAPIKeyHandler_UpdateGroup_NegativeGroupID(t *testing.T) {
  183. svc := &failingUpdateGroupService{
  184. stubAdminService: newStubAdminService(),
  185. err: infraerrors.BadRequest("INVALID_GROUP_ID", "group_id must be non-negative"),
  186. }
  187. router := setupAPIKeyHandler(svc)
  188. rec := httptest.NewRecorder()
  189. req := httptest.NewRequest(http.MethodPut, "/api/v1/admin/api-keys/10", bytes.NewBufferString(`{"group_id": -5}`))
  190. req.Header.Set("Content-Type", "application/json")
  191. router.ServeHTTP(rec, req)
  192. require.Equal(t, http.StatusBadRequest, rec.Code)
  193. require.Contains(t, rec.Body.String(), "INVALID_GROUP_ID")
  194. }
  195. // failingUpdateGroupService overrides AdminUpdateAPIKeyGroupID to return an error.
  196. type failingUpdateGroupService struct {
  197. *stubAdminService
  198. err error
  199. }
  200. func (f *failingUpdateGroupService) AdminUpdateAPIKeyGroupID(_ context.Context, _ int64, _ *int64) (*service.AdminUpdateAPIKeyGroupIDResult, error) {
  201. return nil, f.err
  202. }